fix: use navigateToHome() in ExternalSuccessScreen#686
Merged
Conversation
Match iOS behavior by navigating directly to home after external channel connection success, instead of popping back to TransferRoot.
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Collaborator
Author
Guess not 😞 : https://github.com/synonymdev/bitkit-android/actions/runs/21182710369/job/60929393314?pr=686 |
Member
|
utAck |
jvsena42
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match iOS (and RN) behavior by navigating directly to home after external channel connection success, instead of popping back to TransferRoot.
Description
Previously, tapping the continue button on the External Success screen used
popBackStack<Routes.TransferRoot>(inclusive = true), which didn't explicitly navigate to the Home screen. This caused inconsistent behavior compared to iOS, where the app returns directly to Home after the success screen.The fix changes the navigation to use
navigateToHome(), which properly restores the Home screen without re-composing it. This ensures consistent behavior across platforms and fixes a timing issue with timed sheets in E2E tests. Hopefully fixes@transfer_2flakiness 🤞Preview
QA Notes
Connect to external node
Verify Home screen state